Puppeteer v24 renames the PuppeteerLaunchOptions type to LaunchOptions. The fix from my commit will fix it with the latest version, but likely break builds for users with Puppeteer < 24 installed.

The only option I see is pulling out the type declaration to Crawlee (and therefore not relying on the name of the type, but rather the contents). Wdyt @B4nan @janbuchar ?

yeah let's do that

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

On second thought, we're already using the LaunchOptions type e.g. in puppeteer-crawler here. It has been exported from puppeteer for at least 5 years under this name.

afaiac doing this could only cause issues for users with very ancient Puppeteer versions, who have been using only browser-pool separately (no puppeteer-crawler) until now. Which is IMO very niche (borderline impossible) and I'm in favor of merging as is, i.e. with the commit above.

Oh I see, if the type is there for so long, agreed it sounds safe'ish. Worst case we can deal with this when someone reports a problem with it.